Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified VAR_DIR to include instance name #1664

Merged
merged 1 commit into from Sep 13, 2017

Conversation

jszigetvari
Copy link
Contributor

contrib/solaris-packaging/syslog-ng@default: modified some default values for parameters

* minor improvements to fix possible file collisions across instances
* VAR_DIR will now contain the instance name for non-default instances
  if not defined otherwise
* persist, pid and ctl files will not reflect the instance names, but
  their paths will
* changed VAR_DIR paths

Signed-off-by: Janos SZIGETVARI jszigetvari@gmail.com

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build? (admin please type: ok to test)

@MrAnno
Copy link
Collaborator

MrAnno commented Sep 9, 2017

@kira-syslogng ok to test

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@bazsi
Copy link
Collaborator

bazsi commented Sep 9, 2017

This looks good to me, but I can't test it myself. I can assume that you tested it yourself, right?

@jszigetvari
Copy link
Contributor Author

I can assume that you tested it yourself, right?

As I don't have a Solaris 10-11 test machine for OSE, I haven't . The original version was implemented for PE, I removed the PE-specific parts, and added OSE-specific ones. I did the testing with PE only.
Now I will try to build OSE on Solaris 11 for the sake of testing it.

…de instance name

contrib/solaris-packaging/syslog-ng@default: modified some default values for parameters

    * minor improvements to fix possible file collisions across instances
    * VAR_DIR will now contain the instance name for non-default instances
      if not defined otherwise
    * persist, pid and ctl files will not reflect the instance names, but
      their paths will
    * changed VAR_DIR paths

Signed-off-by: Janos SZIGETVARI <jszigetvari@gmail.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@MrAnno MrAnno merged commit 8bbf883 into syslog-ng:master Sep 13, 2017
@MrAnno
Copy link
Collaborator

MrAnno commented Sep 13, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants