Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch.http: implemented onMessageQueueEmpty function #1668

Conversation

pzoleex
Copy link
Collaborator

@pzoleex pzoleex commented Sep 12, 2017

Fixes: #1509
Flush the message automatically when there are no more message in the queue.
Earlier it caused problem when there were less messages than flush_limit() and syslog-ng
does not flush them only at reload/restart.

Possible side effects: if the messages come slower syslog-ng will flush more often
instead of waiting flush_limit().

The classes inherited from ESNativeClient does not use this method
because the bulkprocessor here is responsible for the auto flush.

Signed-off-by: Zoltan Pallagi pzolee@balabit.com

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

Fixes: syslog-ng#1509
Flush the message automatically when there are no more message in the queue.
Earlier it caused problem when there were less messages than flush_limit() and syslog-ng
does not flush them only at reload/restart.

Possible side effects: if the messages come slower syslog-ng will flush more often
instead of waiting flush_limit().

The classes inherited from ESNativeClient does not use this method
because the bulkprocessor here is responsible for the auto flush.


Signed-off-by: Zoltan Pallagi <pzolee@balabit.com>
@pzoleex pzoleex force-pushed the pzolee-elasticsearch-http-flush-on-message-queue-empty branch from 5561111 to 42b54cb Compare September 13, 2017 08:48
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@furiel furiel merged commit 52b9a57 into syslog-ng:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants