Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml-parser: bugfixes #1684

Merged
merged 3 commits into from Sep 20, 2017
Merged

xml-parser: bugfixes #1684

merged 3 commits into from Sep 20, 2017

Conversation

furiel
Copy link
Collaborator

@furiel furiel commented Sep 20, 2017

  • strip-whitespace option is not copied during clone
  • when exclude pattern is used and the pipe element is cloned, shutdown leads to double free
  • memory leak when exclude patterns is used, and the provided patterns force a string reverse

Now unit tests run on a cloned version of the pipe element instead of the original.

@furiel
xml-parser: strip_whitespaces not set during clone
243cee0 
Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
@furiel
xml-parser: double free with exclude_patterns and clone
0c503e0 
Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
@furiel
xml-parser: possible memory leak with mustreverse exclude_patterns
28512f9 
Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@lbudai lbudai merged commit df0cce3 into syslog-ng:master Sep 20, 2017
@furiel furiel deleted the strip-whitespaces-xml branch May 8, 2018 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbudai lbudai lbudai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@furiel @kira-syslogng @lbudai