Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfg: Free filename after config file inclusion. #1724

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

swstephenson
Copy link
Contributor

Free config file memory after inclusion

Most likely relates to #1317

Signed-off-by: Sam Stephenson sam.stephenson@alliedtelesis.co.nz

Relates to syslog-ng#1317

Signed-off-by: Sam Stephenson <sam.stephenson@alliedtelesis.co.nz>
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build? (admin please type: ok to test)

@swstephenson
Copy link
Contributor Author

This could easily be merged with #1721

@Kokan
Copy link
Collaborator

Kokan commented Oct 19, 2017

@kira-syslogng ok to test

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

Copy link
Collaborator

@bazsi bazsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, the patch seems good to me.

PS: that cfg_lexer_lex() monster function should really be split up, but due to the ugly goto in there that's always considered too risky, even though such errors would quite possibly be easy to spot if that was done.

@Kokan Kokan merged commit 1234966 into syslog-ng:master Oct 20, 2017
@swstephenson swstephenson deleted the 1317 branch October 23, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants