groupingby: add missing "discarded" counter #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
gaborznagy
reviewed
Nov 6, 2017
modules/dbparser/groupingby.c
Outdated
| @@ -387,6 +387,9 @@ grouping_by_init(LogPipe *s) | |||
| GroupingBy *self = (GroupingBy *) s; | |||
| GlobalConfig *cfg = log_pipe_get_config(s); | |||
|
|
|||
| if (!log_parser_init_method(s)) | |||
There was a problem hiding this comment.
Should not grouping-by parser call StatefulParser's init method instead?
gaborznagy
approved these changes
Nov 6, 2017
|
it should. thanks for the comment.
…--
Bazsi
On Mon, Nov 6, 2017 at 9:40 AM, Gábor Nagy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In modules/dbparser/groupingby.c
<#1748 (comment)>:
> @@ -387,6 +387,9 @@ grouping_by_init(LogPipe *s)
GroupingBy *self = (GroupingBy *) s;
GlobalConfig *cfg = log_pipe_get_config(s);
+ if (!log_parser_init_method(s))
Should not grouping-by parser call StatefulParser's init method instead?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1748 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArldocF_YLR9rRif2YcJyKPtQrsvtUMks5szsYWgaJpZM4QSSHD>
.
|
This function is to pair up with log_parser_init_method(), right now it is empty but can be used to tear down state that log_parser_init_method() sets up. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
bazsi
force-pushed
the
grouping-by-missing-discarded-counter
branch
from
f24f438
to
2ddd812
Compare
|
due to @gaborznagy's comment I have now added a broader refactor.
|
|
Build FAILURE, $TEST_DESC_COMMENT |
This patch adds log_parser_init_method() to the init() call chain, where it was missing. This fixes #1738, as well as any potential missing initialization problem in the future. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
bazsi
force-pushed
the
grouping-by-missing-discarded-counter
branch
from
2ddd812
to
232b8c4
Compare
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
@kira-syslogng test this please test branch=pzolee-grouping-by-parser; |
|
Build SUCCESS, the tests were executed on test branch: pzolee-grouping-by-parser and test suite: functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds log_parser_init_method() to the init() call chain,
where it was missing. This fixes #1738, as well as any potential
missing initialization problem in the future.
Signed-off-by: Balazs Scheidler balazs.scheidler@balabit.com