criterion: disabling aslr for testcases #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I needed to remove the quotes in LDFLAGS+=${test_ldflags}. The reason is I got compiler errors: "-no-install -no-pie" is passed as a single argument to the linker, resulting in error. |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
Adding detection for -no-pie, as it seems we cannot expect it to be available on every system. |
Parametrized tests in criterion crashes with aslr enabled. Snaipe/Criterion#208 This can be a problem, because for example in ubuntu 17.04 gcc produces position independent executable code by default. With randomize_va_space > 0, it would lead criterion tests to crash. This patch will compile the tests into a non position independent binary, avoiding the crash. Non test related binaries are untouched. One can check if a binary is non-pie by: $ file modules/xml/tests/test_xml_parser modules/xml/tests/test_xml_parser: ELF 64-bit LSB executable [...] However for syslog-ng binary: $ file ../root/sbin/syslog-ng ../root/sbin/syslog-ng: ELF 64-bit LSB shared object Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
furiel
force-pushed
the
criterion-aslr
branch
from
d36e804
to
7c3487e
Compare
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
lbudai
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrized tests in criterion crashes with aslr enabled.
Snaipe/Criterion#208
This can be a problem, because for example in ubuntu 17.04 gcc
produces position independent executable code by default. With
randomize_va_space > 0, it leads criterion tests to crash.
This patch will compile the tests into a non position independent
binary, avoiding the crash.
Non test related binaries are untouched.
Test:
$ file modules/xml/tests/test_xml_parser
modules/xml/tests/test_xml_parser: ELF 64-bit LSB executable [...]
However for syslog-ng binary:
$ file ../root/sbin/syslog-ng
../root/sbin/syslog-ng: ELF 64-bit LSB shared object