getent: fix group - name to gid calculation #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
@kira-syslogng retest this please test branch=furiel-getent-group; |
|
Build SUCCESS, the tests were executed on test branch: furiel-getent-group and test suite: functions |
|
@kira-syslogng retest this please test branch=furiel-getent-group; |
|
Build SUCCESS, the tests were executed on test branch: furiel-getent-group and test suite: functions |
Kokan
reviewed
Nov 22, 2017
| @@ -77,6 +77,13 @@ _getent_format_array(gchar *name_or_gid, gpointer members, GString *result) | |||
| return TRUE; | |||
| } | |||
|
|
|||
| static gboolean | |||
| _getent_format_array_at_location(gchar *name_or_gid, gpointer location, GString *result) | |||
There was a problem hiding this comment.
Why the new function is needed ?
The original _getent_format_array is not used anywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1757