Fix TLS-based destinations in case of a missing client key/cert #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAnno
changed the title
|
Build FAILURE, the tests were executed on test branch: master and test suite: functions |
MrAnno
force-pushed
the
tls-error-impr
branch
2 times, most recently
from
4d15bec
to
a69eec6
Compare
key_file and cert_file are optional (the client cert is not mandatory). Signed-off-by: László Várady <laszlo.varady@balabit.com>
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
1 similar comment
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
file_exists() has a side effect: it logs when the file can't be opened. Since the && operator is evaluated lazily, the error messages of cert_file were not displayed when the first invocation of file_exists failed (on key_file). Signed-off-by: László Várady <laszlo.varady@balabit.com>
Signed-off-by: László Várady <laszlo.varady@balabit.com>
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
1 similar comment
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
lbudai
approved these changes
Mar 8, 2018
|
@furiel I don't think it's possible. That optimization would be far from an equivalent transformation. But yes, we should refactor this function, its side effect is really misleading. |
tykling
added a commit
to tykling/ansible-roles
that referenced
this pull request
May 28, 2018
…we are just a TLS client, to workaround syslog-ng/syslog-ng#1917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key_file and cert_file are optional (the client cert is not mandatory).
Fixes #1916