pragma module-dependency for optional include #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
success |
Kokan
force-pushed
the
pragma-mod-dep
branch
2 times, most recently
from
f40646c
to
8b93eb2
Compare
Kokan
changed the title
|
failure |
|
success |
|
success |
Kokan
changed the title
furiel
reviewed
Apr 16, 2018
lib/pragma-parser.c
Outdated
| @@ -34,6 +34,7 @@ static CfgLexerKeyword pragma_keywords[] = | |||
| { "include", KW_INCLUDE, }, | |||
| { "module", KW_MODULE, }, | |||
| { "define", KW_DEFINE, }, | |||
| { "module_dependency", KW_MODULE_DEPENDENCY, }, | |||
There was a problem hiding this comment.
Can we call it @requires or similar? That would mean some analogy to php, ruby or emacslisp :)
|
I do not have comment to the code itself. Just a little question on the naming. Apart from that, approve from my side. |
|
... and thanks for the PR ! |
added 2 commits
April 16, 2018 14:39
Signed-off-by: kokan <peter.kokai@balabit.com>
Signed-off-by: kokan <peter.kokai@balabit.com>
|
success |
|
@furiel : thanks! |
|
cool \o/
…--
Bazsi
On Tue, Apr 17, 2018 at 1:00 PM, Budai Laszlo ***@***.***> wrote:
Merged #1956 <#1956>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1956 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AArldr-dDoVdPhc2Ttz4P2abRnR2jk_Zks5tpctagaJpZM4TD7lH>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of
sclhas a hidden dependency for modules to be present. In case of thatscluses a plugin, that is not installed; the syslog-ng is not going to start up even if that specific block is not used in the configuration (but only included).One of the most common example is the
json, if thejsonmodule is not installed, with the default set ofscls syslog-ng is not going to start. There are two main workaround exists for this:This PR aim to give a solution by creating a new pragma keyword, which can specify module requirement. If the requirement is not specified the syslog-ng is going to skip the current file, thus not causing an issue in case of missing module.
Fixes #827.