compat: strnlen impl. if not present #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
success |
furiel
reviewed
Apr 12, 2018
lib/compat/strnlen.c
Outdated
|
|
||
| #if !SYSLOG_NG_HAVE_STRNLEN | ||
|
|
||
| #include <stdint.h> |
There was a problem hiding this comment.
according to man 3 memchr, memchr is included from string.h, which is included from compat/string.h. Do we need this include?
There was a problem hiding this comment.
This is not included because of the memchr, that is guaranteed to be included for the reason you stated above.
And I totally meant stddef.h not stdint.h :), that is needed for size_t. I guess the stddef.h is included at some place either way.
|
success |
Kokan
changed the title
Signed-off-by: kokan <peter.kokai@balabit.com>
Kokan
changed the title
|
success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
strnlenif it is missing from thestring.hheader.@pryankster please test this
Fixes #1982