Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter: multiple filter ref incorrect loop detection #2288

Merged
merged 1 commit into from Sep 18, 2018
Merged

filter: multiple filter ref incorrect loop detection #2288

merged 1 commit into from Sep 18, 2018

Conversation

Kokan
Copy link
Collaborator

@Kokan Kokan commented Sep 18, 2018

In case of skip initialized the visited variable was not set back to FALSE, which would cause false loop detection if the same filter filter would be used twice.

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@Kokan
filter: multiple filter ref incorrect loop detection
7a73730 
Signed-off-by: Kokan <kokaipeter@gmail.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@lbudai
Copy link
Collaborator

lbudai commented Sep 18, 2018

I know that it would be to unfair to request a test... but maybe in a separate PR... ?

@lbudai lbudai merged commit fae6a23 into syslog-ng:master Sep 18, 2018
@lbudai lbudai added this to the OSE 3.18 milestone Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbudai lbudai lbudai approved these changes

@furiel furiel furiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OSE 3.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kokan @kira-syslogng @lbudai @furiel