Fixing some compiler warnings from armv7l #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
d is a glong, but passed as a gint64 pointer to parse_number. This results in a warning, and unexpected write on the stack. Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
MrAnno
approved these changes
Sep 21, 2018
Kokan
approved these changes
Sep 21, 2018
|
Build FAILURE |
|
@kira-syslogng retest this please |
|
Build SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was compiling syslog-ng on armv7l and I found some warnings, that I intend to fix now. (Probably glong->gint64 change is not arm specific.)
I wanted to add
-Wincompatible-pointer-typesto extra warnings, but 4.8 gcc and clang does not know that warning yet. Though with xenial gcc, I could compile without these warnings.Besides these, there were 43 instances
warning: cast increases required alignment of target type [-Wcast-align]that I do not fix for now.