dbparser: fix memory leak #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We leaked the patterndb file after every reload Signed-off-by: Tibor Bodnar <tibor.bodnar@balabit.com>
MrAnno
approved these changes
Sep 26, 2018
Kokan
approved these changes
Sep 26, 2018
|
Build SUCCESS |
furiel
added a commit
to furiel/syslog-ng
that referenced
this pull request
Mar 31, 2019
There was earlier a memory leak in pattern-db: the rules in patterndb were leaked. This was attempted to be fixed in syslog-ng#2311. However the fix was incomplete, the last rule was still not be freed. The problem was in the end element logic: due to the `== 0`, the pdb_rule_unref was called only in case of parse error. Hence rule was never freed at the `</rule>` end element. This patch reverts syslog-ng#2311, and fixes the return value problem. Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We leaked the patterndb file after every reload
Signed-off-by: Tibor Bodnar tibor.bodnar@balabit.com