Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBLD: Add missing docbook-xsl packages #2398

Merged
merged 1 commit into from Nov 7, 2018

Conversation

mitzkia
Copy link
Collaborator

@mitzkia mitzkia commented Nov 7, 2018

Signed-off-by: Andras Mitzki andras.mitzki@balabit.com

 - it installs required xsl files
 - handy when 'http://docbook.sourceforge.net' is unavailable

Signed-off-by: Andras Mitzki <andras.mitzki@balabit.com>
@MrAnno
Copy link
Collaborator

MrAnno commented Nov 7, 2018

--with-docbook=/usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl is hardcoded in dbld/rules. Is it a valid path for all images?

@lbudai
Copy link
Collaborator

lbudai commented Nov 7, 2018

@MrAnno : it might not work on every distrib, but for ubuntu/debian, it is a working path currently.

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@MrAnno MrAnno merged commit 7e0d54f into syslog-ng:master Nov 7, 2018
@mitzkia
Copy link
Collaborator Author

mitzkia commented Nov 7, 2018

@MrAnno Thanks for the finding after installing the 'docbook-style-xsl' package on centos7, docbook.xsl file will be available here: /usr/share/sgml/docbook/xsl-stylesheets-1.78.1/manpages/docbook.xsl.
So the path will be different.

@bazsi
Copy link
Collaborator

bazsi commented Nov 7, 2018 via email

@gaborznagy
Copy link
Collaborator

gaborznagy commented Nov 8, 2018 via email

@lbudai
Copy link
Collaborator

lbudai commented Nov 8, 2018

@gaborznagy : as @bazsi wrote: we need only one official release tarball...
but I would not remove this feature as sometimes (due to some magic issues around autohell tools...) someone need to generate a tarball on a different image than devshell. But this should be a best-effort thing (and I also think that if someone need this feature, that person can easily modify the things that can be modified in order to make it work...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants