New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvements in example-msg-generator #2565
Conversation
Signed-off-by: Terez Nemes <terez.noble@gmail.com>
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
1 similar comment
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
@kira-syslogng ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you consider changing the num
behavior where there is no way to configure msg generator not to send messages (num(0)
). I would define num(0)
as infinite number of messages, and use that as a default value. (negative number to produce infinite number of messages would be fine)
Using zero as infinite in configuration not so uncommon.
Build SUCCESS |
Signed-off-by: Terez Nemes <terez.noble@gmail.com>
Build SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
In this patch I added two changes to
example-msg-generator
. With these changes,example-msg-generator
can be used for testing purposes easier.freq
. With this, the tests can speed up.num
option, users can limit how many messages should be generated. Zero means infinite messages (this is the default). Positive integer means the maximum number of messages.Example: