http: Warn if less workers used than urls #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE |
alltilla
previously approved these changes
May 30, 2019
|
@kira-syslogng retest this please |
|
Build SUCCESS |
|
I think we should give more guidance, what happens in the case that value is lower. |
AFAIK not used urls will work as a failover-server, but I don't think we should advertise this as a feature. |
If less workers are used, then some url targets will not receive messages. We even warn about this in documentation. Signed-off-by: Gabor Nagy <gabor.nagy@balabit.com>
gaborznagy
force-pushed
the
http-url-worker-warning
branch
from
95d559b
to
ba4b35d
Compare
|
Build SUCCESS |
MrAnno
approved these changes
Jun 5, 2019
alltilla
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If less workers are used, then some url targets will not receive messages.
We even warn about this in documentation.