apphook: fix g_thread_init call order issue with older glibs #2853
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
reviewed
Aug 1, 2019
|
Build SUCCESS |
|
The resource init call was the latest addition, and even at that point it
felt early. Getting the base functions in place (logging for instance)
earlier than higher level APIs seems better.
Early startup is tricky and fragile and initializing stuff at the latest
possible point at least reveals potential dependencies. Putting stuff last
is always preferred over putting stuff first.
…On Fri, Aug 2, 2019, 11:01 Gábor Nagy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/apphook.c
<#2853 (comment)>:
> main_loop_thread_resource_init();
msg_init(FALSE);
iv_set_fatal_msg_handler(app_fatal);
iv_init();
- g_thread_init(NULL);
crypto_init();
Oh I think I got it: you mean move the calling of
main_loop_thread_resource_init() instead of the g_thread_init().
Can you explain the reason, please?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2853>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFOK5QNTE7FDFARBBIZJNTQCPZVRANCNFSM4IIR6RAQ>
.
|
|
@bazsi, thanks for the explanation. I hope there is some flexibility inside app_startp, so resolving it will be easier. |
Recently, in app-startup() the g_cond_new() call preceded g_thread_init() call, which only causes issues with glib versions older than 2.32. Signed-off-by: Gabor Nagy <gabor.nagy@balabit.com>
gaborznagy
force-pushed
the
fix-glib-thread-init
branch
from
6476fcc
to
8689179
Compare
|
BTW, except RHEL/Centos 6 all major distributions use 2.4X or higher version of glib, e.g. Centos 7 has 2.56.1. |
|
Build SUCCESS |
furiel
approved these changes
Aug 2, 2019
MrAnno
approved these changes
Aug 2, 2019
|
Milestone added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, in app-startup() the g_cond_new() call preceded g_thread_init() call,
which only causes issues with glib versions older than 2.32, where it is not deprecated.
Fixes #2848