Light property based test fixes #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andras Mitzki <andras.mitzki@balabit.com> Signed-off-by: László Várady <laszlo.varady@protonmail.com>
PR syslog-ng#2907 broke the example-random-generator() driver, this is a follow-up commit. Signed-off-by: Andras Mitzki <andras.mitzki@balabit.com> Signed-off-by: László Várady <laszlo.varady@protonmail.com>
The template() option of pseudofile() is mandatory. pseudofile() is used on pseudo file systems, such as /sys, /proc, and /dev, so it requires a special output format that has to be specified manually by the user. Signed-off-by: Andras Mitzki <andras.mitzki@balabit.com> Signed-off-by: László Várady <laszlo.varady@protonmail.com>
stomp() operates on input that is read from a socket. It is not safe to assume anything about the input. Signed-off-by: László Várady <laszlo.varady@protonmail.com>
|
Build SUCCESS |
|
Sorry for the regression. :( |
furiel
approved these changes
Oct 31, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 4 fixes for bugs we've found with property-based testing method (using Light).
3 of them are trivial; the 4th (stomp() patch) fixes some buffer overrun issues that can be triggered remotely with suitably crafted input.
There are 3 more, but they deserve a separate PR as they are not that trivial.