New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib: add example startup configuration for macOS #3172
Conversation
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
2 similar comments
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Roberto Meléndez rcmelendez@users.noreply.github.com
Ok to test |
Build SUCCESS |
@rcmelendez thank you for your PR. We follow a few formal requirements about contributions. Unfortunately, our contribution guide is not up-to-date. I will update it soon. Until then, let me share what is needed to be changed. Commit formatWe use the following format for commit message:
Signed off line is important, because sometimes the patches are moved around: rebased or cherrypicked, for example during backporting. So that we and github could track the original author, we use the signed off line. For example you can use something like this:
If you do not want to share your email due to privacy reasons, you can use This is needed for the commit checker ci job to pass. News fileWe are generating the newsfile after each release automatically. So that to work, you need to add a news entry into the news directory. You can already find some examples there. In your case you could create news/packaging-3172.md with a content:
If you put the news entry into a second patch, the commit format check needs to be passed on that too. |
Build SUCCESS |
1 similar comment
Build SUCCESS |
On Thu, Mar 12, 2020, 16:42 rcmelendez ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In contrib/com.oneidentity.syslog-ng.plist
<#3172 (comment)>:
> + Tested environment:
+ - macOS Catalina 10.15.3
+ - syslog-ng 3.25
+
+ Location to be stored: /Library/LaunchDaemons
+ Permissions: 644 root:wheel
+ If you need to manually start/stop the job:
+ - Start command: sudo launchctl load /Library/LaunchDaemons/com.oneidentity.syslog-ng.plist
+ - Stop command: sudo launchctl unload /Library/LaunchDaemons/com.oneidentity.syslog-ng.plist
+
+ Author: Roberto Meléndez ***@***.*** on LinkedIn & Medium>
+ Created: March 11, 2020
+-->
+<dict>
+ <key>Label</key>
+ <string>com.oneidentity.syslog-ng</string>
Like com.syslog-ng.plist? For example, the syslogd implementation of
Apple is called: com.apple.syslogd.plist
Yup. syslog-ng is hosted on its own domain, whereas syslogd is just one
piece of apple macos.
|
Finally I could manage to get a working macOS environment and could test the config example. It worked for me (after editing the binary location to my custom install dir). Me seems launchd does not support specifying stop or reload commands. I was hoping we could specify systemctl reload or stop. As I read from the manual, launchd just sends the term signal, and after the timeout, the kill signal. The only configurable thing is the timeout. With that said, I am fine with the current feaute set. |
Build SUCCESS |
Build SUCCESS |
Build SUCCESS |
Build SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
"One last thing" I've found is a PID name conflict, otherwise 👍 :)
Signed-off-by: Roberto Meléndez <rcmelendez@users.noreply.github.com>
Signed-off-by: Roberto Meléndez <rcmelendez@users.noreply.github.com>
Build SUCCESS |
Hi all! Per @furiel comments in the Gitter channel, I'm sharing a working launchd job for syslog-ng 3.25 I tested on macOS. I'm just trying to give Mac users a little help with their syslog-ng experience :)