update contribution guide #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furiel
force-pushed
the
update-contribution-doc
branch
from
e9344ae
to
66811fa
Compare
|
Build SUCCESS |
lbudai
previously approved these changes
Mar 12, 2020
|
Build SUCCESS |
|
There was a bug with github However, I tried Though the macos build is failing for some reason: test-format-cef-extension, test_format_json does not pass. |
MrAnno
reviewed
Mar 17, 2020
MrAnno
previously approved these changes
Mar 17, 2020
alltilla
reviewed
Mar 17, 2020
Signed-off-by: Antal Nemes <antal.nemes.hu@gmail.com>
Signed-off-by: Antal Nemes <antal.nemes.hu@gmail.com>
furiel
force-pushed
the
update-contribution-doc
branch
from
5b461bc
to
94b2baf
Compare
|
Build SUCCESS |
alltilla
approved these changes
Mar 17, 2020
lbudai
approved these changes
Mar 17, 2020
|
@furiel agreed that we should merge this with the 4 approvals we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few things missing from the guide: like news file, how deal with style-check problems, mentioning light.
There are things I think is not necessary: for example opening an issue before pull request.
If you want to see the html-formatted version, just open:
https://github.com/furiel/syslog-ng/blob/update-contribution-doc/CONTRIBUTING.md.