snmp v2 tests in Light #3211

norberttak · 2020-03-30T17:32:30Z

This PR contains the snmpv2 test cases writen in Light test frame work. The snmpv3 tests will be in a separated PR

kira-syslogng · 2020-03-30T17:57:17Z

Build SUCCESS

mitzkia

@norberttak I have started reviewing this branch.
I have opened a new branch in my fork where I give some ideas how SNMP testcases should look like.
https://github.com/mitzkia/syslog-ng/tree/micek_fix_snmp_test2_branch

main remarks:
- there were a lot of string variables in testcases (which are repeated through other testcases), which I refactorized out. It was hard to read testcases with them.
- there were small testcase content issues, where testcase name does not matched with testcase internal actions
- I have removed some unnecessary items from testcases (file_source, keep_hostname=yes). I have replaced file_source with example_msg_generator where message generation is automatic.
- I have separated testcases into smaller directories

Thanks, if you have any question, I am happy to answer.

kira-syslogng · 2020-04-21T12:16:24Z

Build SUCCESS

kira-syslogng · 2020-04-21T15:17:18Z

Build SUCCESS

kira-syslogng · 2020-04-22T08:29:52Z

Build SUCCESS

kira-syslogng · 2020-04-22T09:13:06Z

Build SUCCESS

norberttak · 2020-04-22T10:53:42Z

@mitzkia : I did all the modifications you requested (your commit has been cherry picked + some minor modifications on it).

kira-syslogng · 2020-05-22T11:20:39Z

Build SUCCESS

mitzkia

Finally I would squash all 'functional_tests/destination_drivers/snmp_destination/' testcase commits into one commit (for now there is commit with testcase diffs)

...ests/destination_drivers/snmp_destination/general/test_snmp_destination_reload_statistics.py

tests/python_functional/src/syslog_ng_config/statements/destinations/snmp_destination.py

kira-syslogng · 2020-05-26T12:08:21Z

Build FAILURE

norberttak · 2020-05-27T10:30:14Z

@kira-syslogng retest this please

kira-syslogng · 2020-05-27T10:55:03Z

Build SUCCESS

mitzkia · 2020-05-29T12:49:01Z

Colud you please fix the git commit messages, there are 'fixup' string in some cases.
I found another testcase commit (Light: use get_traps insted of get_logs in test cases)
which can be squashed with big testcase commit.

norberttak · 2020-06-02T13:49:03Z

reword the two commits with "fixup" in title : Done
I don't want to squash the commit "Light: use get_traps instead of get_logs in test cases" because this is a modification of an already existing test case (from an earlier PR) and not a new one. It is a followup of the previous commit in this PR "Light: add better trapd log parsing methode".

kira-syslogng · 2020-06-02T14:09:15Z

Build SUCCESS

alltilla

Nice PR, thanks for this :)

tests/python_functional/src/syslog_ng_ctl/syslog_ng_ctl.py

tests/python_functional/src/syslog_ng_ctl/syslog_ng_ctl_executor.py

tests/python_functional/conftest.py

...ional_tests/destination_drivers/snmp_destination/general/test_snmp_destination_acceptance.py

...ests/destination_drivers/snmp_destination/general/test_snmp_destination_reload_statistics.py

...s/destination_drivers/snmp_destination/v2c/test_snmp_destination_v2c_using_macro_snmp_obj.py

tests/python_functional/src/helpers/snmptrapd/conftest.py

tests/python_functional/src/syslog_ng_ctl/driver_stats_handler.py

kira-syslogng · 2020-06-09T12:20:20Z

Build SUCCESS

kira-syslogng · 2020-06-09T14:03:07Z

Build SUCCESS

kira-syslogng · 2020-06-19T08:57:39Z

Build SUCCESS

kira-syslogng · 2020-06-19T09:23:05Z

Build SUCCESS

Kokan · 2020-06-25T06:30:08Z

...ests/destination_drivers/snmp_destination/general/test_snmp_destination_reload_statistics.py

+    assert snmp_destination.get_stats() == {'written': message_counter, 'processed': message_counter, 'dropped': 0, 'queued': 0}
+
+    syslog_ng.reload(config)
+    message_counter += 1  # example_msg_generator source generates a new message on reload


Note: This is kinda misleading, comment and code here suggest 1 message, while from functional point of view it is message_counter number of messages generated, which in this case happens to be one.
The better pattern imho would be not to use the same variable (as they are relativly free) wtih both configuring the source and the expected messages.

message_counter = 1 expected_message_counter = message_counter ... syslog-ng.start(config) expected_message_counter += message_counter # example msg_generator source generates the messages after reload

@Kokan Thanks for the note. And I am agreed with it, this is a little bit misleading here.

Thanks, I modified the code according to this pattern.

mitzkia

@norberttak Thanks for the PR and the changes.
In my last review I have found only one minor thing, but it can be resolved in another PR also

With this regexp based parsing, the detection of received trap objects is more robust. Furthermore it allows us to enable debug logs in the snmptrapd output Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

Signed-off-by: Andras Mitzki <andras.mitzki@balabit.com>

Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

Add the stats query function to destination driver Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

kira-syslogng · 2020-06-26T10:20:41Z

Build SUCCESS

norberttak changed the title ~~snmp test in Light~~ snmp v2 tests in Light Mar 30, 2020

mitzkia self-requested a review March 31, 2020 08:45

mitzkia suggested changes Apr 5, 2020

View reviewed changes

norberttak force-pushed the snmp-tests2 branch from 12c34e5 to 5c6bf1e Compare April 21, 2020 11:51

norberttak force-pushed the snmp-tests2 branch from 5c6bf1e to 6b508d7 Compare April 21, 2020 14:49

norberttak force-pushed the snmp-tests2 branch from 6b508d7 to 0aa854c Compare April 22, 2020 08:05

norberttak force-pushed the snmp-tests2 branch from 0aa854c to 100544c Compare April 22, 2020 08:51

norberttak force-pushed the snmp-tests2 branch from 100544c to 9526ae5 Compare May 22, 2020 10:56

mitzkia reviewed May 22, 2020

View reviewed changes

norberttak force-pushed the snmp-tests2 branch from 9526ae5 to a12ca16 Compare May 26, 2020 11:46

norberttak force-pushed the snmp-tests2 branch from a12ca16 to 417bd47 Compare June 2, 2020 13:44

alltilla reviewed Jun 5, 2020

View reviewed changes

norberttak force-pushed the snmp-tests2 branch from 417bd47 to 8faecc5 Compare June 9, 2020 11:56

norberttak force-pushed the snmp-tests2 branch 2 times, most recently from bcbc65d to 8ec4bce Compare June 9, 2020 13:42

norberttak force-pushed the snmp-tests2 branch from 8ec4bce to dea21d8 Compare June 19, 2020 08:32

norberttak force-pushed the snmp-tests2 branch from dea21d8 to bb83048 Compare June 19, 2020 09:03

alltilla previously approved these changes Jun 19, 2020

View reviewed changes

Kokan previously approved these changes Jun 25, 2020

View reviewed changes

mitzkia self-requested a review June 26, 2020 08:37

mitzkia previously approved these changes Jun 26, 2020

View reviewed changes

Norbert Takacs and others added 6 commits June 26, 2020 10:59

Light: add better trapd log parsing methode

355cb15

With this regexp based parsing, the detection of received trap objects is more robust. Furthermore it allows us to enable debug logs in the snmptrapd output Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

Light: use get_traps insted of get_logs in test cases

62333e1

Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

LightSyslogNgCtl: Support syslog-ng-ctl query

92e8a54

Signed-off-by: Andras Mitzki <andras.mitzki@balabit.com>

Light: Use INSTANCE_PATH in LightTestcaseParemeters

e58d0d1

Signed-off-by: Andras Mitzki <andras.mitzki@balabit.com>

Light: add stats and query handler calss

7a85b8e

Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

Light: add stats query to destination driver

3caa67f

Add the stats query function to destination driver Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

norberttak dismissed stale reviews from mitzkia, Kokan, and alltilla via 8e858ff June 26, 2020 09:55

norberttak force-pushed the snmp-tests2 branch from bb83048 to 8e858ff Compare June 26, 2020 09:55

Norbert Takacs added 2 commits June 26, 2020 11:55

Light: add snmp v2 test cases

216bf99

Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

news: developer-note-3211

8e858ff

Signed-off-by: Norbert Takacs <norbert.takacs@oneidentity.com>

mitzkia approved these changes Jun 26, 2020

View reviewed changes

Kokan approved these changes Jun 26, 2020

View reviewed changes

Kokan merged commit b9e471d into syslog-ng:master Jun 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

snmp v2 tests in Light #3211

snmp v2 tests in Light #3211

norberttak commented Mar 30, 2020

kira-syslogng commented Mar 30, 2020

mitzkia left a comment •

edited

kira-syslogng commented Apr 21, 2020

kira-syslogng commented Apr 21, 2020

kira-syslogng commented Apr 22, 2020

kira-syslogng commented Apr 22, 2020

norberttak commented Apr 22, 2020

kira-syslogng commented May 22, 2020

mitzkia left a comment •

edited

kira-syslogng commented May 26, 2020

norberttak commented May 27, 2020

kira-syslogng commented May 27, 2020

mitzkia commented May 29, 2020

norberttak commented Jun 2, 2020

kira-syslogng commented Jun 2, 2020

alltilla left a comment

kira-syslogng commented Jun 9, 2020

kira-syslogng commented Jun 9, 2020

kira-syslogng commented Jun 19, 2020

kira-syslogng commented Jun 19, 2020

Kokan Jun 25, 2020

mitzkia Jun 26, 2020

norberttak Jun 26, 2020

mitzkia left a comment

kira-syslogng commented Jun 26, 2020

snmp v2 tests in Light #3211

snmp v2 tests in Light #3211

Conversation

norberttak commented Mar 30, 2020

kira-syslogng commented Mar 30, 2020

mitzkia left a comment • edited

Choose a reason for hiding this comment

kira-syslogng commented Apr 21, 2020

kira-syslogng commented Apr 21, 2020

kira-syslogng commented Apr 22, 2020

kira-syslogng commented Apr 22, 2020

norberttak commented Apr 22, 2020

kira-syslogng commented May 22, 2020

mitzkia left a comment • edited

Choose a reason for hiding this comment

kira-syslogng commented May 26, 2020

norberttak commented May 27, 2020

kira-syslogng commented May 27, 2020

mitzkia commented May 29, 2020

norberttak commented Jun 2, 2020

kira-syslogng commented Jun 2, 2020

alltilla left a comment

Choose a reason for hiding this comment

kira-syslogng commented Jun 9, 2020

kira-syslogng commented Jun 9, 2020

kira-syslogng commented Jun 19, 2020

kira-syslogng commented Jun 19, 2020

Kokan Jun 25, 2020

Choose a reason for hiding this comment

mitzkia Jun 26, 2020

Choose a reason for hiding this comment

norberttak Jun 26, 2020

Choose a reason for hiding this comment

mitzkia left a comment

Choose a reason for hiding this comment

kira-syslogng commented Jun 26, 2020

mitzkia left a comment •

edited

mitzkia left a comment •

edited