Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve func-test #3236

Merged
merged 3 commits into from Jul 16, 2020
Merged

Improve func-test #3236

merged 3 commits into from Jul 16, 2020

Conversation

szemere
Copy link
Collaborator

@szemere szemere commented Apr 14, 2020

  1. While investigating func-test errors - It was easier for me to see the list of failed test cases after each run.
  2. Checking logstore_reader was a dead code, since we returned from the loop on first iteration.

@kira-syslogng
Copy link
Contributor

Build SUCCESS

MrAnno
MrAnno reviewed Apr 16, 2020
View reviewed changes
tests/functional/messagecheck.py Outdated Show resolved Hide resolved
tests/functional/func_test.py Outdated Show resolved Hide resolved
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@MrAnno MrAnno changed the title Improve func-test [WIP] Improve func-test May 26, 2020
@kira-syslogng
Copy link
Contributor

Build SUCCESS

MrAnno
MrAnno previously approved these changes Jun 16, 2020
View reviewed changes
@MrAnno MrAnno changed the title [WIP] Improve func-test Improve func-test Jun 16, 2020
@kira-syslogng
Copy link
Contributor

Build SUCCESS

MrAnno
MrAnno previously approved these changes Jun 24, 2020
View reviewed changes
gaborznagy
gaborznagy suggested changes Jul 2, 2020
View reviewed changes
tests/functional/func_test.py Outdated Show resolved Hide resolved
@szemere
func-test: print the name of failed testcases
70363fc 
Signed-off-by: Laszlo Szemere <laszlo.szemere@oneidentity.com>
@szemere
func-test: remove dead code
e29eea7 
Regardless of the value of logstore_store_supported, logstore_reader
was never tested. We exited from the loop with the first value of
the iterator, which was file reader.

Signed-off-by: Laszlo Szemere <laszlo.szemere@oneidentity.com>
@szemere
news: add developer-note-3236
07f0a7b 
Signed-off-by: Laszlo Szemere <laszlo.szemere@oneidentity.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@gaborznagy gaborznagy merged commit d71220f into syslog-ng:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furiel furiel furiel left review comments

@alltilla alltilla alltilla left review comments

@MrAnno MrAnno MrAnno approved these changes

@gaborznagy gaborznagy gaborznagy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@szemere @kira-syslogng @MrAnno @furiel @gaborznagy @alltilla