RHEL 7 packaging: fix logrotate file conflict with rsyslog

[MrAnno]

Fixes #1384

I had long discussions with Red Hat about it, but renaming it to syslog-ng does not work.
#1384 (comment)

More info: #1384 (comment)

[MrAnno]

@kira-syslogng build packages please

[MrAnno]

@czanik Please tell us when you backport this to the "official" syslog-ng package in EPEL 8.
Thanks for the patch. 👍

[kira-syslogng]

Package Build SUCCESS

Packages are available at https://ci.syslog-ng.com/jenkins/job/kira-dbld-pull-requests/691/artifact/

[kira-syslogng]

Build SUCCESS

[czanik]

Looks good to me. 👍
I plan to work on the official EPEL 8 package next week, as I already spent a lot more time on RPM packaging this week than I planned...

[bazsi]

There was a comment from Evan on the mailing list iirc, where he had concerns about the rename of the logrotate file. Are we handling that somehow?

…

On Wed, Jun 17, 2020, 10:25 Peter Czanik ***@***.***> wrote: ***@***.**** approved this pull request. Looks good to me. 👍 I plan to work on the official EPEL 8 package next week, as I already spent a lot more time on RPM packaging this week than I planned... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3324 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFOK5SQZD4WS6FJQRXTIXLRXB4YBANCNFSM4N7VWPGA> .

[czanik]

No, there is nothing we can do here. In RHEL 8 the rsyslog package has its logrotate file as /etc/logrotate.d/syslog, but has rsyslog specific part in it (reloading rsyslog). If we copy an rsyslog-related logrotate file to /etc/logrotae.d/syslog-ng then the config in the syslog-ng-logrotate subpackage would not overwrite it and would not work.

[bazsi]

What if we ran sed against the config file on installation?

…

On Wed, Jun 17, 2020, 12:20 Peter Czanik ***@***.***> wrote: No, there is nothing we can do here. In RHEL 8 the rsyslog package has its logrotate file as /etc/logrotate.d/syslog, but has rsyslog specific part in it (reloading rsyslog). If we copy an rsyslog-related logrotate file to /etc/logrotae.d/syslog-ng then the config in the syslog-ng-logrotate subpackage would not overwrite it and would not work. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3324 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFOK5TJW6PZKKVVXXETLCLRXCKFBANCNFSM4N7VWPGA> .

[czanik]

No. I ran into too many sed magic fixing corner cases in syslog-ng packaging and causing hard to debug problems later on.

[MrAnno]

https://lists.balabit.hu/pipermail/syslog-ng/2020-June/025949.html

[czanik]

syslog-ng.spec.diff.txt
I did not receive any further feedback, but as it resolves both the original problem (rsyslog & syslog-ng together) and Evan's problem (name change) I think it's good enough. Tested on Fedora 31, CentOS 7 and CentOS 8, and worked everywhere as expected.
As usual, I lack necessary git skills, so ere is a new diff for syslog-ng.spec. I removed my other changes (related to removing java modules). The changelog part is also a bit messed up...

[MrAnno]

Thanks. PR updated.

[MrAnno]

@kira-syslogng build packages, please

[kira-syslogng]

Package Build SUCCESS

Packages are available at https://ci.syslog-ng.com/jenkins/job/kira-dbld-pull-requests/693/artifact/

[czanik]

Thanks! 👍

[kira-syslogng]

Build SUCCESS