New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syslogformat: fix underflow if no bytes left to parse #3329
syslogformat: fix underflow if no bytes left to parse #3329
Conversation
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
2 similar comments
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
@kira-syslogng ok to test |
Build FAILURE |
Thanks for the PR, as I stated in the #3328 issue imho this is far from complete. Additionally it would be great to see a unit test covering this case, as it could both make sure this is not broken again and the once agreed behaviour is documented via the test. The patch also had additional crash prevention after processing Additionally this patch seems to introduce an actual bug caught by test. By default syslog-ng does not process empty lines in a file, but there is an option to do so
Write an empty line into the
Instead the current version prints:
@aleksandrgilfanov Do you have the capacity to push forward this PR based on my comment ? [1] #3328 (comment) |
Closing in favor of #3364. |
Issue: #3328