Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: fix check_nanoseconds() for wsl #3340

Merged
merged 2 commits into from Jun 26, 2020

Conversation

nobles
Copy link
Contributor

@nobles nobles commented Jun 26, 2020

Due to microsoft/WSL#4898,
syslog-ng loops in check_nanoseconds() infinitely.
This is a wsl bug, that will be probably fixed.
On the other hand, syslog-ng should not interpret
EINVAL as expected failure. So this patch fixes
the error handling of nanosleep.

Due to microsoft/WSL#4898,
syslog-ng loops in `check_nanoseconds()` infinitely.
This is a wsl bug, that will be probably fixed.
On the other hand, syslog-ng should not interpret
`EINVAL` as expected failure. So this patch fixes
the error handling of `nanosleep`.

Signed-off-by: Terez Nemes <terez.noble@gmail.com>
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

2 similar comments
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@furiel
Copy link
Collaborator

furiel commented Jun 26, 2020

@kira-syslogng ok to test

Kokan
Kokan previously approved these changes Jun 26, 2020
@kira-syslogng
Copy link
Contributor

Build SUCCESS

Signed-off-by: Terez Nemes <terez.noble@gmail.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@Kokan Kokan merged commit 4e19fa7 into syslog-ng:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants