tlscontext: apply ecdh-curve-list for client, too #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set1_curves_list.html > SSL_CTX_set1_groups() sets the supported groups for ctx to glistlen > groups in the array glist. The array consist of all NIDs of groups in > preference order. For a TLS client the groups are used directly in the > supported groups extension. For a TLS server the groups are used to > determine the set of shared groups. > ... > The curve functions are synonyms for the equivalently named group > functions and are identical in every respect. Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
alltilla
force-pushed
the
ecdh_curve_list_client_side
branch
from
792f6c6
to
76eaa46
Compare
|
Build SUCCESS |
furiel
approved these changes
Jul 14, 2020
MrAnno
approved these changes
Jul 14, 2020
|
I just saw this is a bugfix. In my understanding, this patch makes it possible to restrict curves on the client-side too. |
|
It turned out that not all curves are available by default, so this option can also be used to extend the allowed list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set1_curves_list.html
Signed-off-by: Attila Szakacs attila.szakacs@oneidentity.com