packaging/rhel: remove python3 path fixup in syslog-ng.spec #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log-ng.spec After PR syslog-ng#3647 lib/merge-grammar.py has python3 in it's shebang instead of "python", there is no need for the sed command anymore in the .spec file (python2 is not supported). Also, the sed expression currently creates an invalid python reference, see result: "#!/usr/bin/python33" Packaging CI jobs doesn't hit this issue, as they are creating packages from tarball (as intended due to bison v3.7.6 which is not yet available on many platforms). This bug prevented releasing on rpm platforms where the grammar files are changed. Signed-off-by: Gabor Nagy <gabor.nagy@oneidentity.com>
|
@czanik Can you check this PR, please? |
|
Build SUCCESS |
MrAnno
approved these changes
May 5, 2021
|
👍 tested the change both on RHEL and openSUSE, and both work fine. |
czanik
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #3647 lib/merge-grammar.py has python3 in it's shebang instead of "python",
there is no need for the sed command anymore in the .spec file (python2 is not supported).
Also, the sed expression currently creates an invalid python reference, see result:
#!/usr/bin/python33Packaging CI jobs doesn't hit this issue, as they are creating packages from tarball
(as intended due to bison v3.7.6 which is not yet available on many platforms).
This bug prevented releasing on rpm platforms where the grammar files are changed.
This PR is not critical from OSE release point of view.