Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workers() option to the Redis destination #3732

Merged
merged 3 commits into from Jul 28, 2021
Merged

Add workers() option to the Redis destination #3732

merged 3 commits into from Jul 28, 2021

Conversation

OverOrion
Copy link
Collaborator

This PR adds workers() support for the redis() destination driver.

This increases the throughput of the Redis destination driver.

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

1 similar comment
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@alltilla
Copy link
Collaborator

@kira-syslogng ok to test

@MrAnno MrAnno self-requested a review July 13, 2021 11:52
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@OverOrion OverOrion force-pushed the redis_worker branch 2 times, most recently from a13c5a9 to a887890 Compare July 13, 2021 14:26
@MrAnno
Copy link
Collaborator

MrAnno commented Jul 13, 2021

@kira-syslogng add to whitelist

@kira-syslogng
Copy link
Contributor

Build SUCCESS

Kokan
Kokan reviewed Jul 14, 2021
View reviewed changes
modules/redis/redis.c Outdated Show resolved Hide resolved
modules/redis/redis.h Outdated Show resolved Hide resolved
modules/redis/redis-worker.h Outdated Show resolved Hide resolved
modules/redis/redis-worker.h Outdated Show resolved Hide resolved
modules/redis/redis-worker.c Outdated Show resolved Hide resolved
modules/redis/redis-worker.c Outdated Show resolved Hide resolved
@kira-syslogng
Copy link
Contributor

Build FAILURE

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@alltilla alltilla self-requested a review July 15, 2021 16:23
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@OverOrion OverOrion force-pushed the redis_worker branch 2 times, most recently from 2ea7bde to 5568746 Compare July 21, 2021 15:16
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@alltilla alltilla mentioned this pull request Jul 23, 2021
Merged
Kokan
Kokan previously approved these changes Jul 26, 2021
View reviewed changes
MrAnno
MrAnno previously approved these changes Jul 26, 2021
View reviewed changes
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

modules/redis/redis-worker.c Outdated Show resolved Hide resolved
modules/redis/redis-worker.c Outdated Show resolved Hide resolved
modules/redis/redis-worker.c Outdated Show resolved Hide resolved
@alltilla alltilla removed their request for review July 27, 2021 05:52
@MrAnno
Copy link
Collaborator

MrAnno commented Jul 27, 2021

#3741 has been merged.
@OverOrion Could you please rebase and follow the changes up in the grammar? (batching and workers-related non-terminal symbols)

@OverOrion
redis: replaced compatibility API with the new worker API
e4ad61e 
Signed-off-by: Parrag Szilárd <szilard.parrag@gmail.com>
@OverOrion OverOrion dismissed stale reviews from MrAnno and Kokan via 8ef3318 July 28, 2021 06:58
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@OverOrion
redis: add log_threaded_dest_driver_workers_option
e401e1b 
Signed-off-by: Parrag Szilárd <szilard.parrag@gmail.com>
@OverOrion
news: feature-3732
3984254 
Signed-off-by: Parrag Szilárd <szilard.parrag@gmail.com>
@Kokan
Copy link
Collaborator

Kokan commented Jul 28, 2021

The workers() option does not work, you have to opt in in the grammar using threaded_dest_driver_workers_option.

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@MrAnno
Copy link
Collaborator

MrAnno commented Jul 28, 2021

Thanks.

@MrAnno MrAnno merged commit d4ef662 into syslog-ng:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kokan Kokan Kokan approved these changes

@MrAnno MrAnno MrAnno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OverOrion @kira-syslogng @alltilla @MrAnno @Kokan