Rewrite rename #3841
Merged
Rewrite rename #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for the positional version :) A general confusion already exists when using name-value pairs, due to the I'm not sure which version would be more intuitive for our users, but for me, |
|
Build SUCCESS |
bazsi
reviewed
Nov 17, 2021
bazsi
reviewed
Nov 17, 2021
Kokan
force-pushed
the
rewrite-rename
branch
from
6d28020
to
f91331c
Compare
bazsi
reviewed
Nov 19, 2021
|
Build SUCCESS |
Kokan
force-pushed
the
rewrite-rename
branch
from
f91331c
to
9465b99
Compare
|
Build SUCCESS |
bazsi
reviewed
Nov 19, 2021
Kokan
force-pushed
the
rewrite-rename
branch
from
9465b99
to
fb91d36
Compare
|
Build SUCCESS |
bazsi
approved these changes
Nov 20, 2021
bazsi
previously approved these changes
Nov 24, 2021
Copies source() value into the destination(), and removes the source()
nv entry.
If source() == destination() this means do nothing.
If the source() points to a not existing nv entry, also does nothing.
```
rewrite {
rename( source("from") destination("to") );
}
```
Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
Instead of providing source/destination options, simply use the first
string as source and the second string as destination.
```
rewrite {
rename("old_key" "new_key")
};
```
Signed-off-by: Kokan <kokaipeter@gmail.com>
|
Resolved conflict. |
Kokan
force-pushed
the
rewrite-rename
branch
from
fb91d36
to
d3af25a
Compare
|
Build SUCCESS |
bazsi
approved these changes
Nov 25, 2021
gaborznagy
pushed a commit
to gaborznagy/syslog-ng
that referenced
this pull request
Dec 16, 2021
Signed-off-by: Gabor Nagy <gabor.nagy@oneidentity.com>
bazsi
added a commit
that referenced
this pull request
Dec 21, 2021
news: correct PR number for #3841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a native implementation of #3814. The interface has been tweaked a little with using positional options.
In the following cases the
rename()does not changes the message:source()equals todestination()source()entry not present in the message