amqp: drop message if it is larger than the max frame size #3869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v0.4.0 users of the librabbitmq-c library do not have to negate the result codes when using the error_string() functions. All major distros have fresher than v0.4.0 librabbitmq-c libraries (actually I could not find even one, which does not), so we can just simply change the negation. Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
We are planning to map different AMQP result codes to different LogThreadedResult codes. We cannot do that if afamqp_worker_publish() can only return TRUE or FALSE. Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
We will never be able to send the message, so we should drop it. Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
|
Build SUCCESS |
MrAnno
approved these changes
Jan 6, 2022
bazsi
approved these changes
Jan 6, 2022
gaborznagy
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is also a minor error reporting fix.
Fixes #3820
Signed-off-by: Attila Szakacs attila.szakacs@oneidentity.com