Fix SIGSEGV in the "CONFIG" command over syslog-ng-ctl #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kokan
previously approved these changes
Jan 31, 2022
|
Hmm, it seems that some UT assert on the error message that was changed. |
syslog-ng crashed if the subcommand was missing. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
fix-segv-in-control-config
branch
from
38bcd92
to
75132ec
Compare
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
fix-segv-in-control-config
branch
from
75132ec
to
f354f7b
Compare
Kokan
approved these changes
Jan 31, 2022
|
Build SUCCESS |
MrAnno
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a SIGSEGV triggered by an incorrectly formatted "CONFIG"
command, received on the syslog-ng control socket. The only known
implementation of the control protocol is syslog-ng-ctl itself, which always
sends a correct command, but anyone with access to the UNIX domain socket
syslog-ng.ctl(root only by default) can trigger a crash.