amqp: handle error from amqp_ssl_socket_new() #3929
Conversation
Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
Though in the current implementation it only returns NULL if calloc() fails, which has more serious consequences, it is better to be safe and check it anyways. Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
alltilla
force-pushed
the
amqp-ssl-error-report
branch
from
dd4aa67
to
f367ad2
Compare
|
Build SUCCESS |
|
@alltilla : The problem was originally reported with syslog-ng 3.23, as that is the version in EPEL 8. Does this patch work with 3.23? As in that case I can create an updated package for EPEL 8. Unfortunately EPEL uses fixed versions, so I'm not allowed to update to 3.36 :/ |
|
@czanik I would emphasize that we cannot fix the root of the problem, this change only makes sure that syslog-ng does not crash, instead it reports an error message. So in order to make |
|
@alltilla If it does not work anyway, then it is not worth the effort (doing the backport, preparing a package, submitting it and praying for testers to check it out). In this case we should simply wait for an updated AMQP package. I can try to contact the package maintainer. |
|
Oops. It's part of the base system, not in EPEL. I'll try to contact the RHEL maintainer, but I suspect that even if it works, it will take a lot of time. A quicker way forward might be adding an up-to-date version of rabbitmq to my repo and use that. At least as a temporary solution. |
amqp_ssl_socket_new()can return withNULL, which causes a segfault inamqp_ssl_socket_set_cacert().This change does not fix the problem coming from
amqp_ssl_socket_new(), but handles its error gracefully.Fixes #3924
Signed-off-by: Attila Szakacs attila.szakacs@oneidentity.com