Use generic-number in riemann (4.0) #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no news file needed. |
bazsi
force-pushed
the
use-generic-number-in-riemann
branch
from
2176f47
to
6260aa7
Compare
|
Build SUCCESS |
bazsi
changed the title
bazsi
force-pushed
the
use-generic-number-in-riemann
branch
from
6260aa7
to
4cf05d3
Compare
OverOrion
reviewed
Aug 22, 2022
There was a problem hiding this comment.
I have checked the last commit, and it looks good to me.
I just want to mention that the old behavior was that g_scii_strtoll() returned with 0 if it was unable to parse the string as number, meanwhile the new one only calls the setter if it was parsed successfully.
If #4022 gets merged, then it can get merged too (after a rebase, if needed).
bazsi
force-pushed
the
use-generic-number-in-riemann
branch
from
4cf05d3
to
3267b67
Compare
|
Build FAILURE |
bazsi
force-pushed
the
use-generic-number-in-riemann
branch
from
3267b67
to
547b1cd
Compare
gaborznagy
previously approved these changes
Aug 24, 2022
|
@bazsi Can you rebase this branch for a last time, please? |
…ENT_FIELD_TIME Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
MrAnno
force-pushed
the
use-generic-number-in-riemann
branch
from
547b1cd
to
68ab80e
Compare
MrAnno
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the riemann driver to use GenericNumber and its associated number parsing functions, instead of using using strtoll() without error handling.
This is not really a functional change, rather it is a refactor, but has originally been done in the scope of the 4.0 typing work.