Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: build and publish nightly docker image #4117

Merged
merged 7 commits into from Aug 29, 2022

Conversation

alltilla
Copy link
Collaborator

@alltilla alltilla commented Aug 26, 2022

stable tags will work like it did before.
nightly tag will be nightly. :)

It would be nice to have custom tags for each nightly build, but it would require some clean-up logic, which is not trivial. So we decided to have this for now, and do the advanced tagging later.

Signed-off-by: Attila Szakacs szakacs.attila96@gmail.com

@github-actions
Copy link
Contributor

No news file has been detected. Please write one, if applicable.

bazsi
bazsi previously approved these changes Aug 26, 2022
Copy link
Collaborator

@bazsi bazsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Thanks

@MrAnno MrAnno self-requested a review August 28, 2022 00:24
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
Currently unused, but we will use it in the next commit.

Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
`stable` tags will work like it did before.
`nightly` tag will be `nightly`. :)

It would be nice to have custom tags for each nightly build, but it
would require some clean-up logic, which is not trivial. So we decided
to have this for now, and do the advanced tagging later.

Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
This let's us build nightly docker images.

Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
…ease

Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
@MrAnno MrAnno self-requested a review August 28, 2022 16:16

publish-docker-image:
needs: test-packages
uses: ./.github/workflows/publish-docker-image.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI CDN caches are not invalidated atomically in index-packages.yml, so we can expect apt installation issues during the image build.

I'm not sure how big of a problem it is, but we'll see in action.

@MrAnno MrAnno merged commit a53d77d into syslog-ng:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants