db-parser prefix() support #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No news file has been detected. Please write one, if applicable. |
|
I'm using it in a way that is close to the original idea. When I extract fields from the message I use a prefix so I can more easily map all of the extracted fields into a destination format ".fields.*" is great when I don't know what the fields will be but I need to map them to json in a destination format |
bazsi
force-pushed
the
db-parser-prefix-support
branch
from
b4bbec2
to
7f37297
Compare
|
This is now pretty much complete. Tests are running locally and now in GitHub CI. Let's see if it turns green. |
bazsi
force-pushed
the
db-parser-prefix-support
branch
from
7f37297
to
db12e33
Compare
|
Looks green |
|
@bazsi can this be merged? |
bazsi
force-pushed
the
db-parser-prefix-support
branch
from
db12e33
to
d872002
Compare
|
removed WIP, rebased and added news file. I am trying to get some reviews so this can be merged. In the meantime can you perhaps test this if it works for you? The CI produces a set of binaries, so you don't have to compile it yourself. Thanks |
|
@bazsi sure how do I get bits from a PR? |
|
The current run is here
https://github.com/syslog-ng/syslog-ng/actions/runs/3142427727
It is built by the "packages" github action for every PR. You will find the
packages among the artifacts, for every distro built.
…On Wed, Sep 28, 2022, 14:18 Ryan Faircloth ***@***.***> wrote:
@bazsi <https://github.com/bazsi> sure how do I get bits from a PR?
—
Reply to this email directly, view it on GitHub
<#4133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFOK5RYS76L4HGYCSQGMJLWAQZRJANCNFSM6AAAAAAQMIYNJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Strange the objects are not downloadable must be a github issue I can try again in a bit |
|
@bazsi I was able to download the images my current dev machine is now an apple with M1 I was unable to use the rpm the binary RPMs are x86_64 |
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Remove the duplicated check for stat(db-file). Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
This allows us to get rid of the use of template->name in this instance. Also it improves performance as the name-value pair handle is resolved in init time, instead of at every match. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
…arrays Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
db-parser-prefix-support
branch
from
d872002
to
1b63233
Compare
|
rebased against current master |
MrAnno
approved these changes
Nov 17, 2022
bazsi
added a commit
that referenced
this pull request
Nov 24, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
that referenced
this pull request
Nov 27, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
to bazsi/syslog-ng
that referenced
this pull request
Dec 3, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
that referenced
this pull request
Dec 5, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
that referenced
this pull request
Dec 5, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
MrAnno
pushed a commit
that referenced
this pull request
Dec 5, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
MrAnno
pushed a commit
that referenced
this pull request
Dec 5, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
that referenced
this pull request
Dec 8, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
that referenced
this pull request
Dec 10, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
that referenced
this pull request
Dec 15, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
alltilla
pushed a commit
that referenced
this pull request
Dec 15, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to fix #4130
@ryanfaircloth the original idea behind db-parser() was to be the "global" parser for any kind of data. For that reason, I kind of expected all name-value pairs to be specified right within the pattern database. It kind of failed in that mission, today I view db-parser() as a useful alternative to regexps, because it is MUCH faster. But in this role you are right, prefix() would make sense.
These are just a few preparatory patches, but I wanted to submit them so 1) you see there's progress, 2) I can get feedback via the automatic tests.
In the meanwhile, could you please describe your use-case how you'd apply db-parser() to it? It would be useful to learn from. Thanks.