Light: Remove Python 2 compatibility #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No news file has been detected. Please write one, if applicable. |
mitzkia
force-pushed
the
light_remove_python2_compatibility
branch
from
020e6ee
to
87bbabd
Compare
- with dropping Python 2 support from Light pathlib2 pip package will not needed anymore - instead of pathlib2 Python 3 native pathlib will be used Signed-off-by: Andras Mitzki <mitzkia@gmail.com>
- after dropping Python 2 support Path module will be available via pathlib package Signed-off-by: Andras Mitzki <mitzkia@gmail.com>
Signed-off-by: Andras Mitzki <mitzkia@gmail.com>
- in Python3 we do not need to convert Path objects to string Signed-off-by: Andras Mitzki <mitzkia@gmail.com>
- in Python3 we can use time.monotonic() Signed-off-by: Andras Mitzki <mitzkia@gmail.com>
mitzkia
force-pushed
the
light_remove_python2_compatibility
branch
from
87bbabd
to
a224fba
Compare
Signed-off-by: Andras Mitzki <mitzkia@gmail.com>
- this is only a style-check fix Signed-off-by: Andras Mitzki <mitzkia@gmail.com>
|
Build FAILURE |
|
@kira-syslogng test this please; |
|
Maybe I am wrong, but as I can see new devshell image could built with the changes: If this is true than I would say:
So the changes would work. |
bazsi
approved these changes
Oct 24, 2022
MrAnno
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR:
Additional tasks with this PR: