Apache access log fix for non http requests #4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No news file has been detected. Please write one, if applicable. |
bazsi
force-pushed
the
apache-access-log-fix-for-non-http-requests
branch
from
94a7ffc
to
e18b3ed
Compare
bazsi
changed the title
bazsi
force-pushed
the
apache-access-log-fix-for-non-http-requests
branch
from
e18b3ed
to
a64baac
Compare
smortex
previously approved these changes
Nov 29, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
…s.log Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Sometimes the rawrequest is not a proper HTTP request (e.g. when someone
submits an request like this), handle this case properly.
_default_:443 106.75.178.169 "-" - [22/Nov/2022:00:03:53 +0100] "{\"params\": [\"miner1\", \"bf\", \"00000001\", \"504e86ed\", \"b2957c02\"], \"id\": 4, \"method\": \"mining.submit\"}\n" 400 226 "-" "-"
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
apache-access-log-fix-for-non-http-requests
branch
from
a64baac
to
6bd8cc2
Compare
MrAnno
approved these changes
Dec 5, 2022
bazsi
added a commit
that referenced
this pull request
Dec 8, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
that referenced
this pull request
Dec 10, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
added a commit
that referenced
this pull request
Dec 15, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
alltilla
pushed a commit
that referenced
this pull request
Dec 15, 2022
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added NEWS file, test coverage et al.
This contains a new CSV escaping mode, unit + light tests and a couple of fixes to csv-parser()