add value() parameter to date-parser()#4319
Merged
alltilla merged 6 commits intoFeb 14, 2023
Merged
Conversation
Contributor
|
No news file has been detected. Please write one, if applicable. |
This was referenced Feb 10, 2023
bazsi
added a commit
to bazsi/syslog-ng
that referenced
this pull request
Feb 11, 2023
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
date-parser-add-value-parameter
branch
from
031b2bd to
7517335
Compare
bazsi
added a commit
to bazsi/syslog-ng
that referenced
this pull request
Feb 11, 2023
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
date-parser-add-value-parameter
branch
from
7517335 to
d9df183
Compare
alltilla
reviewed
Feb 13, 2023
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
The implementation is changed to allow for more granular timestamps and eventually to also store a timezone value. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Also add support for storing the timezone offset along with sec/usec. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
This adds support for timezones. Unfortunetely strftime() does not support fractions of a second, so that's not yet supported. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
date-parser-add-value-parameter
branch
from
d9df183 to
122940e
Compare
alltilla
approved these changes
Feb 14, 2023
Collaborator
|
The macOS fail is not related to this PR, it fails on master, too. |
Genfood
pushed a commit
to Genfood/syslog-ng
that referenced
this pull request
Jun 14, 2023
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves 3 things to deliver more complete support for processing non-standard timestamps.
type-hinting: improve the format we can use for DATETIME values by allowing usec granularity (instead of msec) and adding timezone offset information.
date-parser now allows extracting timestamps into a name-value pair (in addition to storing the extracted time in the message timestamps)
$(format-date) now uses the improved datetime format, so the timezone offset is properly handled when formatting the timestamp.