http: Bugfix: http dd does not detect cURL compression support #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE |
2 similar comments
|
Build FAILURE |
|
Build FAILURE |
therandomstring
force-pushed
the
http-curl-fix-no-libz-support
branch
from
b6af632
to
2faf1f2
Compare
|
Build FAILURE |
therandomstring
force-pushed
the
http-curl-fix-no-libz-support
branch
from
2faf1f2
to
1299ba7
Compare
|
Build FAILURE |
therandomstring
force-pushed
the
http-curl-fix-no-libz-support
branch
from
1299ba7
to
7fbd632
Compare
therandomstring
added a commit
to therandomstring/syslog-ng
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
therandomstring
added a commit
to therandomstring/syslog-ng
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
therandomstring
force-pushed
the
http-curl-fix-no-libz-support
branch
from
e6eeff0
to
dbd6f23
Compare
bazsi
force-pushed
the
http-curl-fix-no-libz-support
branch
from
dbd6f23
to
967fbbe
Compare
|
I have cleaned up this patch and compression support somewhat. I am not saying I am perfectly happy, but things improved a lot. I have updated this branch by forcepushing to the original branch @therandomstring I have manually tested the code with compression enabled and it does work, but there was a lot of churn. Some more testing would be appreciated. |
…L has been compiled without Zlib support. Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…ION macro instead Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…grammar Also add proper error handling to unrecognized compression methods. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
http-curl-fix-no-libz-support
branch
from
967fbbe
to
6cbb060
Compare
|
I am merging these with my latest changes. That moves the http compression implementation to something closer to what I would expect. I've also fixed a bug which caused the "Content-Encoding" header to be included in each request 16 times (more exactly the number of workers times) |
alltilla
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the compilation of http_dd with compression options only detected the presence of Zlib. This caused a compilation error when Zlib was found, but cURL on the system has been compiled without it.