Avoid using the deprecated GTimeVal type #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is an alternative to #4479 |
|
Build FAILURE |
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
from
fdb0ac5
to
faf59e1
Compare
|
Build FAILURE |
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
from
0845018
to
650dbbc
Compare
|
Build FAILURE |
bazsi
changed the title
|
@kira-syslogng retest this please; |
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
from
650dbbc
to
0d454e8
Compare
|
Build FAILURE |
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
2 times, most recently
from
e4ffb76
to
78daa4b
Compare
|
Build FAILURE |
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
from
78daa4b
to
2547ec3
Compare
|
Build FAILURE |
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
from
2547ec3
to
9b989f7
Compare
|
Build FAILURE |
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
from
9b989f7
to
57d5a1e
Compare
|
Build FAILURE |
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
2 times, most recently
from
1a39fb8
to
6a87f07
Compare
This function is actually a cache and we will need this in a subsequent patch from within cache.c. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
… code Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
We are using iv_now to track the current monotonic time which requires the initialization of ivykis from all threads. This is true for all production threads for syslog-ng, but may not be for test programs etc. This patch adds iv_init()/deinit() calls to these cases. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
The dnscache is using time for internal purposes, which is better of using the ivykis provided iv_now which tracks CLOCK_MONOTONIC rather than REALTIME. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Note that previously the rate-limiting was slightly more accurate as it queried an accurate time for every invocation. This is now using a cached time, but that should be fine for a rate limit. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
upgrade-glib-min-version-to-2-68
branch
from
6a87f07
to
bbbf8e7
Compare
|
@kira-syslogng do stresstest |
|
Kira-stress-test: Build FAILURE |
alltilla
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with #4739 it turned out that the easy fix for that is to upgrade
GLIB_MIN_VERSION to 2.68.
But glib deprecated GTimeVal that is scattered around the code. This branch gets rid of GTimeVal but does not bump the glib min version to 2.68 as we will need to add further changes to be warning free on 2.68
no news needed