bigquery: Fixed missing check of the dependent C++ switch in cmake config #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HofiOne
force-pushed
the
Fix-missing-dependency-check-in-BIGQUERY-cmake
branch
from
9561941
to
4967527
Compare
|
Build FAILURE |
HofiOne
force-pushed
the
Fix-missing-dependency-check-in-BIGQUERY-cmake
branch
2 times, most recently
from
8b97d8d
to
378dd1d
Compare
|
Build FAILURE |
…ike we have in other GRPC modules) Yes, I know, i do not like it either, i would like to bring back in an upcoming round all the module switches for all the C++ modules (regardless if it is a GRPC-dependent or simple C++ one), but in a separate run. Also, please NOTE that we do not have per-module switches now, as we removed them earlier based on an agreement. Also, we still/again have none matching settings in the cmake and autotools config files, I'd liket to sync them again in the above mentioned upcoming C++/GRPC module switch re-introduction round. Signed-off-by: Hofi <hofione@gmail.com>
HofiOne
force-pushed
the
Fix-missing-dependency-check-in-BIGQUERY-cmake
branch
from
378dd1d
to
b599525
Compare
alltilla
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, I know, i do not like it either, i would like to bring back in an upcoming round all the module switches for all the C++ modules (regardless if it is a GRPC-dependent or simple C++ one), but in a separate run.
Also, please NOTE that we do not have per-module switches now in any of the GRPC C++ modules, as we removed them earlier based on an agreement.
Also, we still/again have none matching settings in the cmake and autotools config files, I'd like to sync them too again in the above mentioned upcoming C++/GRPC module switch re-introduction round.
Signed-off-by: Hofi hofione@gmail.com