Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Corrects and updates links #983

Merged
merged 6 commits into from
Apr 3, 2016
Merged

Conversation

fekete-robert
Copy link
Collaborator

No description provided.

Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Others
------

Binaries for other platforms might be available, please check out the
Binaries for other platforms are listed at the
official [third party page][3rd-party] for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fekete-robert We should probably remove for more information in this formulation, because the sentence is now ill formed.

@lbudai
Copy link
Collaborator

lbudai commented Mar 17, 2016

👍

@bkil-syslogng
Copy link
Contributor

@lbudai Did you see the issue I've noted above?

Until this gets fixed, 👎 from me

"Binaries for other platforms are listed at the official third party page for more information."

@lbudai
Copy link
Collaborator

lbudai commented Mar 17, 2016

@bkil-syslogng : you are right

@fekete-robert
Copy link
Collaborator Author

@lbudai @bkil-syslogng Updated and somewhat expanded

@bkil-syslogng
Copy link
Contributor

👍 A few sentences sound a bit odd, but at least the end result can now be parsed and is presentable.

@bazsi
Copy link
Collaborator

bazsi commented Mar 22, 2016

we still don't have the feedback@ alias, so we shouldn't merge this before that happens.

I've opened a ticket at our IT team, let's hope it works out fast.

@bazsi
Copy link
Collaborator

bazsi commented Apr 3, 2016

The feedback alias is in place, so I am merging this.

@bazsi bazsi merged commit 8ccbea3 into syslog-ng:master Apr 3, 2016
@bazsi bazsi removed the needs-review label Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants