Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mysql-forward_autocommit #3253

Open
2 tasks
renecannao opened this issue Jan 18, 2021 · 0 comments
Open
2 tasks

Deprecate mysql-forward_autocommit #3253

renecannao opened this issue Jan 18, 2021 · 0 comments

Comments

@renecannao
Copy link
Contributor

renecannao commented Jan 18, 2021

mysql-forward_autocommit is incorrectly used (it creates complex and incorrect logics), while often users really need mysql-enforce_autocommit_on_reads.
It is also possible that the current implementation is broken, so deprecating it now makes sense.

We should:

  • remove any reference in the code related to mysql_thread___forward_autocommit
  • if mysql-forward_autocommit is set to true , report a warning in the error log saying that the variable is deprecated

This to be applied only to 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant