Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several improvement for MySQL_Monitor #490

Closed
10 tasks done
renecannao opened this issue Feb 27, 2016 · 0 comments
Closed
10 tasks done

Several improvement for MySQL_Monitor #490

renecannao opened this issue Feb 27, 2016 · 0 comments
Assignees
@renecannao
Labels
ADMIN CONNECTION POOL GLOBAL MONITOR MYSQL PROTOCOL
Milestone
Truls

Comments

@renecannao
Copy link
Contributor

WHAT

  • Make access to MySQL_Monitor_Connection_Pool() (the connection pool used only by MySQL Monitor) thread-safe
  • implement a mechanism to purge removed hosts from MySQL_Monitor_Connection_Pool() (related to connection leak when restarting proxysql #473)
  • drop all connections from MySQL_Monitor_Connection_Pool() when shutting down (related to connection leak when restarting proxysql #473)
  • drop all connections in active monitoring threads when shutting down (related to connection leak when restarting proxysql #473) : this is always true, as is it the normal procedure while exiting from a loop
  • ping only if server is not OFFLINE_HARD
  • check replication lag only if server is not OFFLINE_HARD
  • check read_only only if server is not OFFLINE_HARD
  • LOAD MYSQL GLOBAL VARIABLES should resets timers to immediately triggers new checks
  • LOAD MYSQL GLOBAL VARIABLES should drop all connections to re-establish them
  • keep maximum 2 connections per backend
@renecannao renecannao self-assigned this Feb 27, 2016
@renecannao renecannao added this to the Truls milestone Feb 27, 2016
renecannao added a commit that referenced this issue Feb 27, 2016
@renecannao
Added mutex in MySQL_Monitor_Connection_Pool()
b8109f1 
Issue #490
- Access to MySQL_Monitor_Connection_Pool was not thread-safe
renecannao added a commit that referenced this issue Feb 27, 2016
@renecannao
purge removed hosts from MySQL_Monitor_Connection_Pool()
01a5a71 
Related to #490 and #473
renecannao added a commit that referenced this issue Feb 27, 2016
@renecannao
drop all connections from MySQL_Monitor_Connection_Pool() when shutti…
3a1912c 
…ng down

Issues #490 and #473
renecannao added a commit that referenced this issue Feb 27, 2016
@renecannao
LOAD MYSQL GLOBAL VARIABLES resets MySQL Monitor timers
4c53273 
And immediately triggers new checks
Issue #490
renecannao added a commit that referenced this issue Feb 27, 2016
@renecannao
LOAD MYSQL GLOBAL VARIABLES drop all Monitor conns
aa73d52 
Issue #490
LOAD MYSQL GLOBAL VARIABLES TO RUNTIME drops all MySQL Monitor connections so that they can be re-established
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renecannao renecannao

Labels
ADMIN CONNECTION POOL GLOBAL MONITOR MYSQL PROTOCOL
Projects
None yet
Milestone
Truls
Development

No branches or pull requests
1 participant
@renecannao