Renamed CPP to CXX in Makefiles #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed all variables in Makefiles that have 'CPP' in the name to 'CXX': "CFLAGS enables the addition of switches for the C compiler, while CXXFLAGS is meant to be used when invoking a C++ compiler. Similarly, a variable CPPFLAGS exists with switches to be passed to the C or C++ preprocessor." (https://en.wikipedia.org/wiki/CFLAGS) This change facilitates the building with customized CXXFLAGS (rpmbuild exports a customized CXXFLAGS with hardening flags).
|
Thank you Augusto. I created #1053 to remind myself to apply this to future 1.3.8 and 1.41 . current master branch is not updated. |
renecannao
added a commit
that referenced
this pull request
Jun 27, 2017
renecannao
added a commit
that referenced
this pull request
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed all variables in Makefiles that have 'CPP' in the name to 'CXX':
"CFLAGS enables the addition of switches for the C compiler, while
CXXFLAGS is meant to be used when invoking a C++ compiler. Similarly, a
variable CPPFLAGS exists with switches to be passed to the C or C++
preprocessor." (https://en.wikipedia.org/wiki/CFLAGS)
This change facilitates the building with customized CXXFLAGS (rpmbuild
exports a customized CXXFLAGS with hardening flags).
More 2 links:
https://stackoverflow.com/questions/495598/difference-between-cppflags-and-cxxflags-in-gnu-make
https://stackoverflow.com/questions/5541946/cflags-ccflags-cxxflags-what-exactly-do-these-variables-control