Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default_track_gtids config value being ignored #2813

Conversation

arthurschreiber
Copy link
Contributor

@arthurschreiber arthurschreiber commented May 20, 2020

When a new backend connection is opened, the session_track_gtids config variable would be set from the default specified in the proxysql configuration, but it was actually never sent to MySQL (via a SET SESSION command).

This changes the code to actually send the expected SET SESSION command.


A reproducible test case can be found here: https://github.com/arthurschreiber/proxysql-issue/tree/default-session-track-gtid-issue

When a new backend connection was selected, the `session_track_gtids` config variable would be marked as set, but was never actually set on the backed connection.
@pondix
Copy link
Contributor

pondix commented May 20, 2020

Automated message: PR pending admin approval for build testing

@renecannao renecannao changed the base branch from v2.0.12 to v2.0.13 May 20, 2020 16:35
@renecannao
Copy link
Contributor

ok to test

@renecannao
Copy link
Contributor

@arthurschreiber :

A reproducible test case can be found here: https://github.com/github/proxysql-issues/tree/default-session-track-gtid-issue

The link doesn't work. Is it a private repo?

@arthurschreiber
Copy link
Contributor Author

The link doesn't work. Is it a private repo?

Ah yes, I linked the wrong repo. I'll get that fixed asap.

@arthurschreiber
Copy link
Contributor Author

@renecannao renecannao merged commit 92e031b into sysown:v2.0.13 May 24, 2020
@renecannao
Copy link
Contributor

Thank you @arthurschreiber !

@arthurschreiber arthurschreiber deleted the arthur/fix-default-track-gtid-config branch May 25, 2020 09:45
@renecannao
Copy link
Contributor

@arthurschreiber : can you please confirm the client are never using session_track_gtids=ALL_GTIDS ?

We need to make some change to the current implementation, because proxysql should track session_track_gtids with value OWN_GTID even if client sets it to OFF.
In other words, we need to decouple client setting from backend setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants