Resolves #3583 - Session fast forward enabled when COM_BINLOG_DUMP_GTID is received #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the basic changes for this. TBD if any cleanup or other changes are needed when changing the state of the session in this way. Feedback appreciated. |
jaredev
changed the title
|
This needs a way for testing it consistently. |
|
Automated message: PR pending admin approval for build testing |
|
retest this please |
* Added COM_BINLOG_DUMP_GTID command to enum_mysql_commands with value 30 (0x1e) based on https://dev.mysql.com/doc/internals/en/com-binlog-dump-gtid.html
* If the COM_BINLOG_DUMP_GTID is received, a warning is logged, and then the session_fast_foward is set to true
For commands BINLOG_DUMP, BINLOG_DUMP_GTID and REGISTER_SLAVE a lot of the features provided by ProxySQL aren't useful, like multiplexing, query parsing, etc. For this reason, ProxySQL enable fast_forward when it receives these commands.
This test runs a custom binlog client, that uses libslave, to test that ProxySQL activates fast forward automatically after receiving the command, and to test that it can read the binlog events. The custom client reads the binlog after sending a query that do not disables multiplexing and after sending a query that disables multiplexing.
|
retest this please |
Fix honoring of 'connect_timeout_server_max' and 'connect_retries_on_failure' for 'fast_forward' sessions created by 'MYSQL_COM_BINLOG_DUMP' when session still doesn't own a backend connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue 3583
Enables session fast forwarding if the COM_BINLOG_DUMP_GTID command is received.