Fixes and improvements found during LDAP testing #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or handling If 'mysql_stmt_store_result' fails with an error, it currently fails to update the internal state machine for 'stmt', announcing that the fetch operation has completed.
This commit packs fixes for test 'prepare_statement_err3024' and also adds regression tests for: - ProxySQL handling of binary resultsets with ERR packets. - Fix for 'mysql_stmt_store_result' from 'libmariadbclient'.
|
Retest this please |
|
retest this please |
1 similar comment
|
retest this please |
…ROCESSING_STMT_PREPARE'
This commit also introduces the following changes: - Fix invalid formatting of 'stats_mysql_users' when username exceeds '256' characters. - Improve error handling in utility function 'string_format'. - Add new utility functions 'cstr_format', as improved versions of previous 'string_format' function.
'COM_STMT_EXECUTE' invalidly reported the 'digest' value from the previous query when preceded by a 'COM_QUERY'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: DO NOT MERGE
This PR holds several fixes and improvements as a result of the testing performed during LDAP plugin development. Detailed information of everything fixed is WIP.