Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor 'Group replication' rework #4082

Merged
merged 7 commits into from Jan 30, 2023
Merged

Conversation

JavierJF
Copy link
Collaborator

@JavierJF JavierJF commented Jan 16, 2023

This is a rework for Monitor 'Group Replication', this reworks reuses the Monitoring model already taken for AWS Aurora for 'Group Replication'.

It also:

  • Add native support to MySQL 8 group replication, deprecating the previously required view sys.gr_member_routing_candidate_status.
  • Fixes a couple of bugs that triggered extra servers re-configurations for GR.

This is a draft of a rework for Monitor 'Group Replication', this
reworks reuses the Monitoring model already taken for AWS Aurora for
'Group Replication'.
When writer was set as SHUNNED due to replication lag, and
'mysql_servers' table was regenerated (via servers reconfiguration or
other action). SHUNNED writer wasn't considered a found writer,
triggering an unwanted server reconfiguration.
@mirostauder
Copy link
Collaborator

retest this please

1 similar comment
@mirostauder
Copy link
Collaborator

retest this please

…writers'

Since servers present in 'backup_writer_hostgroup' where not considered
as previously configured writers, everytime the number of available
writers exceeded 'max_writers' an unwanted server reconfiguration was
triggered for each of these servers at every monitoring action.
@renecannao
Copy link
Contributor

@JavierJF : I took the freedom to resolve the conflict. I hope it makes sense

@JavierJF JavierJF force-pushed the v2.x-group_replication_rework branch from dfb4a5a to e98d028 Compare January 30, 2023 09:32
@JavierJF JavierJF force-pushed the v2.x-group_replication_rework branch from e98d028 to 1188b0e Compare January 30, 2023 11:06
@mirostauder
Copy link
Collaborator

retest this please

@JavierJF JavierJF marked this pull request as ready for review January 30, 2023 18:11
@JavierJF JavierJF changed the title DRAFT: Monitor 'Group replication' rework Monitor 'Group replication' rework Jan 30, 2023
@renecannao
Copy link
Contributor

retest this please

@renecannao renecannao merged commit 4547128 into v2.x Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants