Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SSLKEYLOGFILE #4236

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Added support for SSLKEYLOGFILE #4236

merged 4 commits into from
Jun 6, 2023

Conversation

rahim-kanji
Copy link
Collaborator

  • 'admin-ssl_keylog_file' variable has been introduced to allow users to specify the path for the SSLKEYLOG file. The file path can be an absolute path or relative to the ProxySQL data directory.
  • Assigning an empty path to the 'admin-ssl_keylog_file' variable signifies that the SSLKEYLOG file feature is disabled.
  • In case an invalid path is provided for the SSLKEYLOG file, ProxySQL will automatically revert to the last valid path value.
  • 'PROXYSQL FLUSH LOGS' command can be used to rotate SSLKEYLOG file.

@rahim-kanji rahim-kanji changed the title Added support for SSLKEYLOGFILE DONOT MERGE: Added support for SSLKEYLOGFILE Jun 1, 2023
* 'admin-ssl_keylog_file' variable has been introduced to allow users to specify the path for the SSLKEYLOG file. The file path can be an absolute path or relative to the ProxySQL data directory.
* Assigning an empty path to the 'admin-ssl_keylog_file' variable signifies that the SSLKEYLOG file feature is disabled.
* In case an invalid path is provided for the SSLKEYLOG file, ProxySQL will automatically revert to the last valid path value.
* 'PROXYSQL FLUSH LOGS' command can be used to rotate SSLKEYLOG file.

# Conflicts:
#	lib/mysql_connection.cpp
@rahim-kanji
Copy link
Collaborator Author

retest this please

@rahim-kanji rahim-kanji changed the title DONOT MERGE: Added support for SSLKEYLOGFILE Added support for SSLKEYLOGFILE Jun 6, 2023
@rahim-kanji rahim-kanji marked this pull request as ready for review June 6, 2023 10:11
@renecannao
Copy link
Contributor

@mirostauder : before merging this PR we need to have the feature always enabled on CI

* Updated proxysql sslkeylogfile warning message
@renecannao renecannao merged commit 0acf5bd into v2.x Jun 6, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants